Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): Fix mdn_url for selectors and types #836

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Dec 19, 2024

Description

fix mdn_url for selectors and types

for Adjacent sibling combinator and Subsequent-sibling combinator, rename and fix mdn_url to match the mdn/content

for IE-specifed feature, simply remove the mdn_url key

for non-existed mdn docs, remove the mdn_url key

for redirected mdn docs, update the mdn_url key

found using https://github.com/skyclouds2001/mdn-tools/blob/master/checks/mdn_url-check.js and result store in https://github.com/skyclouds2001/mdn-tools/blob/master/results/incorrect_mdn_url.json

Motivation

Additional details

Related issues and pull requests

@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 19, 2024 07:15
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner December 19, 2024 07:15
@skyclouds2001 skyclouds2001 requested review from pepelsbey and removed request for a team December 19, 2024 07:15
@skyclouds2001 skyclouds2001 changed the title Fix mdn_url for selectors and types fix(css): Fix mdn_url for selectors and types Dec 19, 2024
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

@pepelsbey pepelsbey merged commit f5689dc into mdn:main Dec 21, 2024
3 checks passed
@skyclouds2001 skyclouds2001 deleted the mdn_url-selector-type branch December 21, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants